Skip to content

Pass on the command to redis-cli#446

Merged
sroze merged 4 commits intomasterfrom
feature/fix-sentinel-command
Feb 3, 2018
Merged

Pass on the command to redis-cli#446
sroze merged 4 commits intomasterfrom
feature/fix-sentinel-command

Conversation

@kierenevans
Copy link
Copy Markdown
Collaborator

Abstraction fail :D

@sroze
Copy link
Copy Markdown
Member

sroze commented Dec 13, 2017

Haha. By the way, why bash -c 'container ...' in the run command? You shouldn't need it.

@kierenevans
Copy link
Copy Markdown
Collaborator Author

Sorted 👍
It was leftover from experimentation with commands, then it got too unwieldy and we moved to functions inside the docker image.

Comment thread redis/3-highly-available/README.md Outdated
- /bin/bash
- -c
- 'container run_master_and_sentinel'
- container
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you want that on one line tho

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean container run_master_and_sentinel on one line

…in case it was one that got removed but wasn't noticed.
sroze
sroze previously requested changes Dec 14, 2017
Copy link
Copy Markdown
Member

@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this two line container command?

Copy link
Copy Markdown
Member

@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sroze sroze merged commit 4dff1fb into master Feb 3, 2018
@sroze sroze deleted the feature/fix-sentinel-command branch February 3, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants