Add PHP 7.2 images in base and Symfony varients#460
Merged
Conversation
Collaborator
|
Hey @andytson-inviqa! Great work so far - thank you. |
Collaborator
|
#461 should sort the FROM_TAG issue out 🤞 |
PHP 7.2 removed mcrypt extension and moved to pecl.php.net. Magento and Drupal aren't yet ready for it. Both additionally require mcrypt, however it'd be bad practice to include the pecl one. Instead a mcrypt polyfill could be used by the app.
andytson-inviqa
force-pushed
the
feature/php-7.2
branch
from
2f8d124 to
192e7bd
Compare
kierenevans
approved these changes
Feb 13, 2018
Member
|
We need to regenerate the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 7.2 removed mcrypt extension and moved to pecl.php.net.
Magento and Drupal aren't yet ready for it. Both additionally require mcrypt, however it'd be bad practice to include the pecl one. Instead a mcrypt polyfill could be used by the app.