Skip to content

Fix Opcache's validate_timestamps setting always being 1#462

Merged
kierenevans merged 1 commit intomasterfrom
feature/fix-opcache-validate-timestamps-always-being-1
Feb 13, 2018
Merged

Fix Opcache's validate_timestamps setting always being 1#462
kierenevans merged 1 commit intomasterfrom
feature/fix-opcache-validate-timestamps-always-being-1

Conversation

@kierenevans
Copy link
Copy Markdown
Collaborator

The check against DEVELOPMENT_MODE not being "true" did succeed, but the PHP_OPCACHE_VALIDATE_TIMESTAMPS value was already set, so it got used in 55-stack

@sroze
Copy link
Copy Markdown
Member

sroze commented Feb 13, 2018

Why is that for? When you set the environment variable PHP_OPCACHE_VALIDATE_TIMESTAMPS=0 yourself, it disables it on development mode? 🤔

@kierenevans
Copy link
Copy Markdown
Collaborator Author

You could set to 0 yourself which would make sure no changes to php files are reflected in the loading of the next page, but you wouldn't want that in development.
I think the original intent of the setting was to ensure this is set to 0 unless DEVELOPMENT_MODE is set to "true", as it gives better performance - it's just it got set to 1 by mistake as it inherited the first setting of it.

@kierenevans
Copy link
Copy Markdown
Collaborator Author

Sorry, re-read your message - setting it to 0 yourself in development will persist correctly.

@kierenevans kierenevans force-pushed the feature/fix-opcache-validate-timestamps-always-being-1 branch from 05966cd to d2de4fc Compare February 13, 2018 08:21
@kierenevans kierenevans merged commit e21bfa4 into master Feb 13, 2018
@kierenevans kierenevans deleted the feature/fix-opcache-validate-timestamps-always-being-1 branch February 13, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants