Build in groups to avoid timeout#469
Merged
kierenevans merged 2 commits intomasterfrom Mar 9, 2018
Merged
Conversation
hgajjar
reviewed
Mar 9, 2018
hgajjar
left a comment
hgajjar
left a comment
There was a problem hiding this comment.
Looks good, does it help to build all images again?
Collaborator
Author
|
Yep! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History of builds is not great - some images haven't been built in ages due to timeouts.
I have a hunch it's per a TideCommand timeout so splitting into two groups should hopefully help us get past it.
Tagging as "Ready for Review" to see how far the build gets.