Docs/solve - #871
Merged
Merged
Conversation
Fixes the spec's own accessor list: is_empty(sol) doesn't exist (is_empty only takes a TimeGridModel, not a Solution) — the real solution-level check is is_empty_time_grid(sol), which the page now uses. Drops the "Solution struct" section (API-reference material) and the inline export/import note (now results/save-load.md's job). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Ports the attic almost entirely (thorough, mostly current per spec), with two real fixes found by executing it for real: - CTModels.jl#392 (the VBox plotting bug from PR 5/6) turns out to affect nearly every bare plot(sol) call in this file specifically — triggered whenever the default (empty) description is used, regardless of styles or layout kwargs. Fixed throughout with explicit :state/:costate/:control selectors or layout=:group, with one clear note up front rather than repeating it everywhere. - The flow-plotting section's saveat=fine_grid no longer works as a call-time keyword; it moved to Flow's construction-time options and now needs a companion dense=false to avoid a SciML-level dense/saveat conflict. Rewrote the subsection around the working form, verified live (117 points vs 19 on the default grid). Trimmed the plotattr()/Plots.attributes() <details> blocks — generic Plots.jl mechanics, not OptimalControl API. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
First time export_ocp_solution/import_ocp_solution are documented on the site. All claims verified live: exact JLD2/JSON3 round-trip, the double-extension footgun (filename="sol.jld2" writes sol.jld2.jld2), the real ExtensionError text for both missing backends, and that a reloaded solution works as an init= warm start identically to a fresh one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rk board Full julia --project=docs docs/make.jl + npx vitepress build rebuild, clean: 0 undefined-binding/no-docs/duplicate-docs warnings, all three results/ pages' @example blocks execute, 0 unresolved @refs from them. test/suite/shape/test_shape_contract.jl re-run (27/27 passed). typos clean. All 6 acceptance criteria ticked against that build; two real findings beyond the checklist recorded in the report: CTModels.jl#392 affecting nearly every bare plot(sol) call in the attic source, and an off-by-3 line citation in the spec for the plot ExtensionError. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
docs: results — reading, plotting, and persisting a solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.