[pull] master from TryGhost:master#32
Merged
pull[bot] merged 5 commits intocooldashing24:masterfrom Jun 24, 2020
Merged
Conversation
refs #10318 - At the moment there were no test checking correct behavior of `?type` parameter. Given ongoing settings refactoring work expanded tests with some essential coverage - Moved one of the test cases to be consistent with order in other suites
no issue - There are no functional differenec between canary and v3 APIs at the moment, thus these test suites should be kept in sync
refs #10318 - There was a copy/paste error and we didn't have a test to pick it up. Will follow up with a regression test to make sure it doesn't happen again
refs #10318 - `group` - to replace the `type` column, provides a more descriptive name for the columns use - for existing sites it will be populated by migrating data from the `type` column in a later migration - for new sites a minimal update has been added to `parseDefaultSettings()` to populate the `group` field when settings are created during startup - fixes the NOT NULL constraint on `settings.group` - `flags` - signifies special handling that is different to other settings in a group - eg, `PUBLIC,RO` would indicate that the setting is available via unauthenticated endpoints and is read-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )