fix(backups): validate S3 storage before scheduling

[andrasbacsai]

Summary

• Validate selected S3 storage when creating scheduled database backups, rejecting missing or non-team-owned storage.
• Force-disable S3 backup settings when editing an existing schedule with invalid or unavailable S3 storage, including dependent local-backup deletion settings.
• Preserve the previous S3 storage ID in backup job error messages before clearing invalid configuration.
• Add feature coverage for S3 validation during backup creation, editing, and job execution.

[andrasbacsai]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

This PR adds S3 storage ownership and availability validation to database backup workflows. It captures the prior s3_storage_id in DatabaseBackupJob before clearing it, ensuring exception messages report the correct value when S3 storage is deleted. The BackupEdit component extends customValidate() to disable S3 if the selected storage is not in the team's available list. Similarly, CreateScheduledBackup adds a validation gate in submit() to reject S3-enabled backups without a valid team-owned S3 storage. Supporting model changes include adding team_id to S3Storage::$fillable and explicit integer casting for ScheduledDatabaseBackupExecution::size.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch s3-backup-validation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/Livewire/Project/Database/CreateScheduledBackup.php`:
- Around line 52-58: In submit(), replace the stale mount-time snapshot check
that uses $this->definedS3s->contains('id', $this->s3StorageId) with a fresh DB
existence query scoped to the current team: when $this->saveToS3 and
$this->s3StorageId is set, perform an existence check (e.g., query the S3
storage model for team_id = currentTeam()->id and id = $this->s3StorageId using
exists()) and if it does not exist dispatch the same error and return; update
the logic around $this->saveToS3, $this->s3StorageId, and submit() accordingly
so runtime ownership/authorization is validated at submit time.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cbeb2378-f9d0-4d52-9405-916c18ad84d1

📥 Commits

Reviewing files that changed from the base of the PR and between a49bc5d and a4d75ff.

📒 Files selected for processing (8)

• app/Jobs/DatabaseBackupJob.php
• app/Livewire/Project/Database/BackupEdit.php
• app/Livewire/Project/Database/CreateScheduledBackup.php
• app/Models/S3Storage.php
• app/Models/ScheduledDatabaseBackupExecution.php
• tests/Feature/BackupEditValidationTest.php
• tests/Feature/CreateScheduledBackupValidationTest.php
• tests/Feature/DatabaseBackupJobTest.php