sao: Do not trigger an extra read for an empty rec_name [CUSTOM] #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmousset
previously approved these changes
Mar 19, 2024
Collaborator
|
Le code en soit est OK (tant qu'à faire il faudrait le patch pour tryton dans tryton/gui/window/view_form/model/field.py) Par contre ce qui me choque c'est qu'un rec_name puisse être une chaine vide, car alors comment faire la différence entre un M2O avec une valeur et un autre qui vaut NULL ? Ou comment effacer la valeur ? Je me demande si ce n'est pas plutôt ça qu'on devrait faire. |
Contributor
Author
|
@nicoe Là on est sur une vue liste dans une recherche, donc la question de la modification ne se pose pas. Et contextuellement on peut avoir des cas. Après ça pourrait être intéressant d'avoir un "placeholder" pour ça. |
…can_be_empty_string
JCavallo
added a commit
that referenced
this pull request
Mar 21, 2024
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Sep 3, 2024
nicoe
added a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Sep 26, 2024
… [CUSTOM] (coopengo#170)" This reverts commit ce201f1.
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Jun 16, 2025
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Jun 19, 2025
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Sep 11, 2025
JCavallo
added a commit
to JCavallo/tryton
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PCLAS-711