Skip to content

sao: Do not trigger an extra read for an empty rec_name [CUSTOM] #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2024
Merged

sao: Do not trigger an extra read for an empty rec_name [CUSTOM] #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5948c40
sao: Do not trigger an extra read for an empty rec_name
JCavallo Mar 19, 2024
ff997a0
same fix for gtk
JCavallo Mar 21, 2024
9c2e0f7
Merge remote-tracking branch 'origin/master' into PCLAS-711/rec_name_…
JCavallo Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sao/src/model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2208,8 +2208,8 @@
set: function(record, value) {
var promise;
var rec_name = (
record._values[this.name + '.'] || {}).rec_name || '';
if (!rec_name && (value >= 0) && (value !== null)) {
record._values[this.name + '.'] || {}).rec_name;
if (!rec_name && rec_name !== '' && (value >= 0) && (value !== null)) {
var model_name = record.model.fields[this.name].description
.relation;
rec_name = Sao.rpc({
Expand Down
4 changes: 2 additions & 2 deletions tryton/tryton/gui/window/view_form/model/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,8 +594,8 @@ def set_client(self, record, value, force_change=False):
force_change=force_change)

def set(self, record, value):
rec_name = record.value.get(self.name + '.', {}).get('rec_name') or ''
if not rec_name and value is not None and value >= 0:
rec_name = record.value.get(self.name + '.', {}).get('rec_name')
if rec_name is None and value is not None and value >= 0:
try:
result, = RPCExecute('model', self.attrs['relation'], 'read',
[value], ['rec_name'])
Expand Down