Skip to content

fix(attachments): preserve extensions when shortening filenames - #2613

Merged
jonathanKingston merged 1 commit into
mainfrom
codex/preserve-long-attachment-extensions
Sep 9, 2026
Merged

fix(attachments): preserve extensions when shortening filenames#2613
jonathanKingston merged 1 commit into
mainfrom
codex/preserve-long-attachment-extensions

Conversation

@jonathanKingston

Copy link
Copy Markdown
Collaborator

Long video and archive filenames lose their extension when storage truncates the whole name to 80 characters, causing valid attachments to be rejected as unsupported. Shorten the sanitized stem while reserving space for the extension. Regression tests attach long MOV and ZIP names, verify the bounded storage filename, and read the stored bytes back.

Validation: pnpm run check; focused regressions were verified to fail before the fix and pass afterward. These changes affect data/tool operations with unchanged DOM and layout.

After the full check, rebased onto updated main and repeated typechecking plus the focused regression suite on the rebased code.

github-actions Bot added a commit that referenced this pull request Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@copse-release-bot

Copy link
Copy Markdown
Contributor

Reference screenshots ready for review

Review GitHub’s image diffs in screenshot PR #2619.
Merge it (or enable auto-merge) to apply the accepted PNGs to codex/preserve-long-attachment-extensions.

Rendered for cae85d89e0a9 by CI run 34304181899; the immutable artifact is reference-screenshot-candidates-34304181899.

If this source branch moves, a later successful render closes the stale review PR and replaces this link.

@jonathanKingston
jonathanKingston merged commit ab75067 into main Sep 9, 2026
23 checks passed
@jonathanKingston
jonathanKingston deleted the codex/preserve-long-attachment-extensions branch September 9, 2026 02:56
github-actions Bot added a commit that referenced this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant