fix(attachments): preserve extensions when shortening filenames - #2613
Merged
Conversation
Contributor
🖥️ PR preview
|
Contributor
Reference screenshots ready for reviewReview GitHub’s image diffs in screenshot PR #2619. Rendered for If this source branch moves, a later successful render closes the stale review PR and replaces this link. |
jonathanKingston
deleted the
codex/preserve-long-attachment-extensions
branch
September 9, 2026 02:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long video and archive filenames lose their extension when storage truncates the whole name to 80 characters, causing valid attachments to be rejected as unsupported. Shorten the sanitized stem while reserving space for the extension. Regression tests attach long MOV and ZIP names, verify the bounded storage filename, and read the stored bytes back.
Validation:
pnpm run check; focused regressions were verified to fail before the fix and pass afterward. These changes affect data/tool operations with unchanged DOM and layout.After the full check, rebased onto updated main and repeated typechecking plus the focused regression suite on the rebased code.