Skip to content

Show images in proposed changes - #2637

Merged
jonathanKingston merged 2 commits into
mainfrom
codex/proposed-image-previews
Sep 9, 2026
Merged

Show images in proposed changes#2637
jonathanKingston merged 2 commits into
mainfrom
codex/proposed-image-previews

Conversation

@jonathanKingston

Copy link
Copy Markdown
Collaborator

Summary

  • render proposed image changes as before and after previews instead of binary text
  • preserve raster bytes across staging, approval, delete, and rename flows
  • add focused unit, renderer, and Electron visual coverage

Testing

  • pnpm run typecheck
  • pnpm run build
  • pnpm test -- diff-queue local-workspace-fs image-path git-changes-pane-proposed-fetch
  • pnpm run test:e2e -- --spec tests/e2e/git-changes-image.e2e.ts
  • pnpm run check:e2e-syntax
  • pnpm run check: static gates passed; the broad unit phase cannot complete in the managed sandbox because loopback-listener tests fail with EPERM and leave network-sensitive workers running

Visual evidence

The focused Electron spec updates tests/e2e/screenshots/git-changes-image-proposed.png with the proposed before and after preview plus approval controls.

@copse-release-bot

Copy link
Copy Markdown
Contributor

Reference screenshots ready for review

Review GitHub’s image diffs in screenshot PR #2638.
Merge it (or enable auto-merge) to apply the accepted PNGs to codex/proposed-image-previews.

Rendered for c1802fedaa82 by CI run 34390166541; the immutable artifact is reference-screenshot-candidates-34390166541.

If this source branch moves, a later successful render closes the stale review PR and replaces this link.

Screenshot candidates rendered for parent PR
#2637 at
`c1802fedaa82669c66ad4923fd3fb0d5ee9b72b6` by
[CI run
34390166541](https://github.com/copse-dev/agent-pane/actions/runs/34390166541).

Review GitHub's image diffs, then merge this PR (or enable auto-merge)
to apply the
accepted references to `codex/proposed-image-previews`. This branch
contains
only PNG candidates from the immutable
`reference-screenshot-candidates-34390166541` artifact and never targets
`main`.

If the parent branch has advanced beyond the source SHA above, do not
merge this PR;
the successful CI run for the new head will replace it.

Co-authored-by: jonathanKingston <338988+jonathanKingston@users.noreply.github.com>
@jonathanKingston
jonathanKingston enabled auto-merge (squash) September 9, 2026 21:58
github-actions Bot added a commit that referenced this pull request Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@jonathanKingston
jonathanKingston merged commit 1add28a into main Sep 9, 2026
17 checks passed
@jonathanKingston
jonathanKingston deleted the codex/proposed-image-previews branch September 9, 2026 22:09
github-actions Bot added a commit that referenced this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant