Skip to content

Fix settings button edge hit target - #2649

Merged
jonathanKingston merged 1 commit into
mainfrom
codex/settings-button-hit-target-pr
Sep 10, 2026
Merged

Fix settings button edge hit target#2649
jonathanKingston merged 1 commit into
mainfrom
codex/settings-button-hit-target-pr

Conversation

@jonathanKingston

Copy link
Copy Markdown
Collaborator

Summary

  • keep the entire visible Settings footer above the pane resizer’s invisible overlap
  • add an Electron regression assertion for the button’s far-right edge

Testing

  • corepack pnpm run check
  • corepack pnpm run build
  • corepack pnpm run test:e2e -- --spec tests/e2e/portrait-panel-controls.e2e.ts

github-actions Bot added a commit that referenced this pull request Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@copse-release-bot

Copy link
Copy Markdown
Contributor

Reference screenshots ready for review

Review GitHub’s image diffs in screenshot PR #2650.
Merge it (or enable auto-merge) to apply the accepted PNGs to codex/settings-button-hit-target-pr.

Rendered for 3ffd2fc76aca by CI run 34511087523; the immutable artifact is reference-screenshot-candidates-34511087523.

If this source branch moves, a later successful render closes the stale review PR and replaces this link.

@jonathanKingston
jonathanKingston merged commit f5f1764 into main Sep 10, 2026
24 checks passed
@jonathanKingston
jonathanKingston deleted the codex/settings-button-hit-target-pr branch September 10, 2026 23:05
github-actions Bot added a commit that referenced this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant