Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses https://vmproduct.atlassian.net/browse/CORL-2371 by fixing a bug causing staff badges to not be added to the appropriate comments. It also begins a fixture collection for server side testing
What changes to the GraphQL/Database Schema does this PR introduce?
None.
How do I test this PR?
Create 2 sites under the same tenants, and a story for each site, as well as a member with the role of Staff,
Observe that as a Staff user, you receive Staff badges on both stories.
Additionally:
Create an Admin user, an Organization moderator, a Site moderator for the first site, a Site moderator for the second site and a general commenter.
Observe that:
How do we deploy this PR?
This PR should not require any special actions to deploy.