[CORL-2525]: Replace invalid URL anchor tag with text in comments#3890
Merged
kodiakhq[bot] merged 3 commits intodevelopfrom Mar 21, 2022
Merged
[CORL-2525]: Replace invalid URL anchor tag with text in comments#3890kodiakhq[bot] merged 3 commits intodevelopfrom
kodiakhq[bot] merged 3 commits intodevelopfrom
Conversation
|
✅ Deploy Preview for gallant-galileo-14878c canceled. 🔨 Explore the source changes: 5d0bb40 🔍 Inspect the deploy log: https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6238b67e4b7ccc00091c3e09 |
nick-funk
approved these changes
Mar 17, 2022
Contributor
nick-funk
left a comment
nick-funk
left a comment
There was a problem hiding this comment.
Tested this and it even works great with the suspect/banned words highlighting!
tessalt
added
the
🚀 merge it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes better handle the case where a comment includes an anchor tag with an invalid URL for its href. Instead of throwing an error, it will turn the anchor tag into text. See docs for info about invalid URLs: https://developer.mozilla.org/en-US/docs/Web/API/URL/URL
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
Check out the test and see that it's working as expected.
How do we deploy this PR?