Conversation
alinhle
reviewed
Aug 24, 2017
graph/typeDefs.graphql
Outdated
| # Sort the results by created_at. | ||
| sort: SORT_ORDER = REVERSE_CHRONOLOGICAL | ||
| # Sort the results by from largest first. | ||
| sort: SORT_ORDER = DESC |
Contributor
There was a problem hiding this comment.
Hm I intuitively thought that this should be called sortOrder instead.
Conflicts: client/coral-admin/src/reducers/moderation.js client/coral-embed-stream/src/actions/stream.js client/coral-embed-stream/src/components/Stream.js client/coral-framework/components/Slot.js plugin-api/beta/client/utils/index.js test/server/routes/api/account/index.js
Conflicts: package.json
kgardnr
approved these changes
Aug 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
8-alpinefrom8(due to new 🎊 full JS bcrypt library), reducing resulting image size by ~65% or cutting off 600MB. Yes, you heard that right, 65% smaller.sortByto comment/reply edges which allows comments to be sorted in more flexible ways.groupByfunctionality.SortOptionpresentational Component, awithSortOptionHOC providing the props, and acreateSortOptionfactory method combining the previous two toplugin-apiviewingOptionsSortandviewingOptionsFilter. Removed slotviewingOptions.talk-plugin-offtopictalk-plugin-sort-most-liked,talk-plugin-sort-most-replied,talk-plugin-sort-newest,talk-plugin-sort-oldestchildFactoryandcomponentprops to theSlotcomponent.sorttosortOrder.Still in progress, expect more to come here...
Migration
In order for these non-atomic updates to be maintained, we require that after this feature is made available, you run:
At least once to update the cached values on the models that depend on them.