Skip to content

Optimizations and User Sort#870

Merged
kgardnr merged 53 commits intomasterfrom
user-sort
Aug 28, 2017
Merged

Optimizations and User Sort#870
kgardnr merged 53 commits intomasterfrom
user-sort

Conversation

@wyattjoh
Copy link
Contributor

@wyattjoh wyattjoh commented Aug 21, 2017

What does this PR do?

  • Adds support for tracking of action mods and new replies by emitting to a new server side event emitter.
  • Added tests surrounding emitter usage.
  • Renamed sort fields of CHRONO -> ASC/DSC.
  • Removed unused and outdated E2E code.
  • Removed unused dependancies.
  • Moved Front End dependancies from devDependancies -> dependancies.
  • Optimized comment count edges.
  • Action based queries involving comments no longer grab all the things from the comments collection, instead utilized a smart, cached, indexed field on the comments to directly query them.
  • Replaced docker image with 8-alpine from 8 (due to new 🎊 full JS bcrypt library), reducing resulting image size by ~65% or cutting off 600MB. Yes, you heard that right, 65% smaller.
  • Added new sortBy to comment/reply edges which allows comments to be sorted in more flexible ways.
  • Added more to plugin reaction HOC to support new groupBy functionality.
  • Support the new sorting params in stream
  • Add a SortOption presentational Component, a withSortOption HOC providing the props, and a createSortOption factory method combining the previous two to plugin-api
  • Added new slots viewingOptionsSort and viewingOptionsFilter. Removed slot viewingOptions.
  • Adapted talk-plugin-offtopic
  • Added plugins talk-plugin-sort-most-liked, talk-plugin-sort-most-replied, talk-plugin-sort-newest, talk-plugin-sort-oldest
  • Added support for childFactory and component props to the Slot component.
  • Changed sort to sortOrder.

Still in progress, expect more to come here...

Migration

In order for these non-atomic updates to be maintained, we require that after this feature is made available, you run:

./bin/cli verify db --fix

At least once to update the cached values on the models that depend on them.

# Sort the results by created_at.
sort: SORT_ORDER = REVERSE_CHRONOLOGICAL
# Sort the results by from largest first.
sort: SORT_ORDER = DESC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I intuitively thought that this should be called sortOrder instead.

@kgardnr kgardnr merged commit 1ba5fd0 into master Aug 28, 2017
@kgardnr kgardnr deleted the user-sort branch August 28, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants