Replace workflow advance with step-tagged submit_output - #731
Merged
TheGreatAxios merged 3 commits intoAug 31, 2026
Merged
Conversation
Untagged completion could skip ahead on retry. Completing a step now requires the current step id on submit_output, compared atomically so duplicate and stale calls acknowledge without advancing.
submit_output treated every non-current id as already complete, so a future step looked finished. Report past ids as complete and unknown or future ids as not current.
The handler reconstructed the cursor before the director mutated on tool.done, so parallel submit_output could both claim an advance. complete() now returns already-complete vs not-current and the handler reports that result. autoAdvance is removed from the plugin contract because the coordinator no longer reads it.
TheGreatAxios
force-pushed
the
cl-7266-replace-advance_workflow-with-idempotent-step-tagged
branch
from
August 31, 2026 15:40
2592ac5 to
1042db1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submit_output, compared atomically so duplicate and stale calls acknowledge without advancing.Verification
bun run testwas blocked by host git hooks rejecting fixture authors (CL-7267 is the helper for that).Fixes CL-7266