Do not overwrite unreadable run.json on rename - #734
Merged
Conversation
The default resume picker is still running and cancelled only; document --force for failed and done. Silence tests pin a file log sink so a console leak fails. renameSession throws instead of clobbering corrupt state, and the TUI does not persist a snapshot after that failure.
TheGreatAxios
commented
Aug 31, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
renameSession refuses to clobber unreadable run.json; silence tests pin the file sink; picker docs match --force.
No findings.
TheGreatAxios
commented
Aug 31, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Comment
renameSession throws on unreadable run.json and leaves the bytes; TUI persist runs only on fulfill. Silence tests pin a file sink and assert stdout/stderr unused before spy restore.
No remaining findings.
TheGreatAxios
enabled auto-merge
August 31, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renameSessionthrows instead of overwriting an unreadablerun.json; a missing file still gets a fresh running record.--forceincludes failed and done.Verification
bun run typecheck,bun run build, andbun run testpassRelated to CL-7287
skip CL-7287