Keep a second credential error from failing the session - #926
Merged
TheGreatAxios merged 3 commits intoSep 12, 2026
Merged
Conversation
A rebuilt agent reused seq 0 for the next same-category inference error, so commitErrors threw Duplicate error record and afterCheckpoint failed the run. Resume the durable error sequence on assembly and drop a colliding flush instead of failing the session.
TheGreatAxios
force-pushed
the
cl-7738-do-not-fail-the-session-when-a-second-credential-error-hits
branch
from
September 12, 2026 04:09
f3c223e to
bc81652
Compare
TheGreatAxios
commented
Sep 12, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Approve
The three patched vendor packages have complete ledgers and source markers, and createAgent safely falls back when loadErrors fails while preserving normal error-sequence resume.
No findings.
Notes
bun test tests/unit/vendor-patch-ledger.test.ts— 2 pass, 0 fail.bun test vendor/intx-agent/src/flush-errors.test.ts— 10 pass, 0 fail, including cross-assembly sequence resume, duplicate flush handling, andloadErrorsfailure fallback.
A stale-seq assembly flushing [seq0/dup, seq1/fresh] discarded the whole batch, losing fresh diagnostics. The flush now maps the colliding key back to its record, drops only that record, and retries the rest in the same flush.
TheGreatAxios
deleted the
cl-7738-do-not-fail-the-session-when-a-second-credential-error-hits
branch
September 12, 2026 05:06
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run typecheck,bun run build, andbun run testpassFixes CL-7738