Skip to content

Conversation

@jtrh
Copy link
Contributor

@jtrh jtrh commented Dec 22, 2020

@jtrh jtrh self-assigned this Dec 22, 2020
@jtrh jtrh marked this pull request as ready for review December 22, 2020 19:27
@jtrh jtrh requested a review from glarrain December 22, 2020 19:27
@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #172 (694e260) into develop (a7a78e1) will decrease coverage by 1.37%.
The diff coverage is 55.04%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #172      +/-   ##
===========================================
- Coverage    78.14%   76.77%   -1.38%     
===========================================
  Files           26       27       +1     
  Lines         1725     1834     +109     
  Branches       279      308      +29     
===========================================
+ Hits          1348     1408      +60     
- Misses         256      282      +26     
- Partials       121      144      +23     
Impacted Files Coverage Δ
cl_sii/rtc/data_models_cesiones_periodo.py 55.04% <55.04%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a78e1...694e260. Read the comment docs.

@jtrh jtrh changed the title rtc.data_models_cesiones_periodo: Add CesionesPeriodoEntry rtc: Add data model for "Cesiones Periodo" entries Dec 22, 2020
@jtrh jtrh merged commit 0f7a3ba into develop Dec 22, 2020
@jtrh jtrh deleted the feature/add-rtc-cesiones-periodo-data-model branch December 22, 2020 19:30
@glarrain
Copy link
Contributor

glarrain commented Dec 22, 2020

@jtrh It would be nice to convert them to pydantic dataclasses and be able to remove most of the awful type checking code, don't you agree?

@jtrh
Copy link
Contributor Author

jtrh commented Dec 22, 2020

It would be nice to convert them to pydantic dataclasses and be able to remove most of the awful type checking code, don't you agree?

@glarrain The AEC and generic Cesion data models are like that. After they're finished it'll be the turn of CesionesPeriodoEntry.

@jtrh jtrh mentioned this pull request Jan 11, 2021
@jtrobles-cdd jtrobles-cdd added enhancement New feature or request and removed feature labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: rtc enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants