Skip to content

Conversation

@jtrh
Copy link
Contributor

@jtrh jtrh commented Jan 11, 2021

jtrh and others added 19 commits December 15, 2020 22:50
The URL of Cryptography's FAQ page had changed.
build(deps): bump coverage from 4.5.3 to 5.3
…data-model

rtc: Add data model for "Cesiones Periodo" entries
"Data validation and settings management using python type annotations."

"pydantic enforces type hints at runtime, and provides user friendly
errors when data is invalid."

- https://pydantic-docs.helpmanual.io
- https://github.com/samuelcolvin/pydantic
The `zone` attribute is not defined in the abstract base class
`datetime.tzinfo`. We need to check that it is there before using it in
the function `validate_dt_tz` to prevent unexpected exceptions when
dealing with Python Standard Library time zones that are instances of
class `datetime.timezone`.
…lidate-dt-tz

libs.tz_utils: Add checks to validate_dt_tz
- Add `CesionNaturalKey` class.
- Add `CesionAltNaturalKey` class.
- Add tests.
Use `CESION_MONTO_CEDIDO_FIELD_MIN_VALUE` constant in validation of
`CesionesPeriodoEntry.monto_cedido`.
…-cesion-nat-keys

rtc: Add constants and "cesión" natural keys
build(deps): bump codecov from 2.1.9 to 2.1.11
@jtrh jtrh added the kind: release Release label Jan 11, 2021
@jtrh jtrh self-assigned this Jan 11, 2021
@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #178 (1bf1cc8) into master (fe96847) will decrease coverage by 0.52%.
The diff coverage is 70.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   78.14%   77.62%   -0.53%     
==========================================
  Files          26       28       +2     
  Lines        1725     1908     +183     
  Branches      279      319      +40     
==========================================
+ Hits         1348     1481     +133     
- Misses        256      280      +24     
- Partials      121      147      +26     
Impacted Files Coverage Δ
cl_sii/rtc/data_models_cesiones_periodo.py 55.04% <55.04%> (ø)
cl_sii/rtc/data_models.py 92.64% <92.64%> (ø)
cl_sii/libs/tz_utils.py 64.70% <100.00%> (+14.70%) ⬆️
cl_sii/rtc/constants.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe96847...1bf1cc8. Read the comment docs.

@jtrh jtrh requested a review from glarrain January 11, 2021 21:56
@jtrh jtrh merged commit ba55f4e into master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants