libs.tz_utils: Add checks to validate_dt_tz #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `zone` attribute is not defined in the abstract base class `datetime.tzinfo`. We need to check that it is there before using it in the function `validate_dt_tz` to prevent unexpected exceptions when dealing with Python Standard Library time zones that are instances of class `datetime.timezone`.
Codecov Report
@@ Coverage Diff @@
## develop #175 +/- ##
===========================================
+ Coverage 76.77% 76.79% +0.02%
===========================================
Files 27 27
Lines 1834 1836 +2
Branches 308 308
===========================================
+ Hits 1408 1410 +2
Misses 282 282
Partials 144 144
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zoneattribute is not defined in the abstract base classdatetime.tzinfo. We need to check that it is there before using it inthe function
validate_dt_tzto prevent unexpected exceptions whendealing with Python Standard Library time zones that are instances of
class
datetime.timezone.