extras: add 'RutField' for Django forms #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaselc
force-pushed
the
feature/add-dj-form-field
branch
from
2615101 to
a0a3214
Compare
Codecov Report
@@ Coverage Diff @@
## develop #197 +/- ##
===========================================
+ Coverage 80.88% 80.98% +0.10%
===========================================
Files 30 31 +1
Lines 2511 2535 +24
Branches 377 380 +3
===========================================
+ Hits 2031 2053 +22
- Misses 306 307 +1
- Partials 174 175 +1
Continue to review full report at Codecov.
|
yaselc
force-pushed
the
feature/add-dj-form-field
branch
from
a0a3214 to
c8e871d
Compare
Contributor
|
LGTM. Alas, the approval must come from @jtrh |
glarrain
reviewed
Feb 19, 2021
yaselc
force-pushed
the
feature/add-dj-form-field
branch
from
c8e871d to
28835e9
Compare
jtrh
approved these changes
Feb 22, 2021
Contributor
jtrh
left a comment
jtrh
left a comment
There was a problem hiding this comment.
There're a few suggestions in the review comments.
yaselc
force-pushed
the
feature/add-dj-form-field
branch
from
28835e9 to
138eda0
Compare
Contributor
|
@yaselc remember #197 (comment) |
yaselc
force-pushed
the
feature/add-dj-form-field
branch
from
138eda0 to
3a4d48a
Compare
A separate field class for Django form
yaselc
force-pushed
the
feature/add-dj-form-field
branch
from
3a4d48a to
9209bca
Compare
glarrain
approved these changes
Feb 26, 2021
jtrh
approved these changes
Feb 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A separate field class for Django form
Previous: #5