Skip to content

Conversation

@glarrain
Copy link
Contributor

@glarrain glarrain commented Apr 4, 2019

A separate field class for:

  • Django model.
  • DRF (Django REST Framework) serializer.
  • MM (marshmallow) schema.

Some tests have not been implemented.

@codecov-io
Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #5 into develop will decrease coverage by 26.53%.
The diff coverage is 51.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop       #5       +/-   ##
============================================
- Coverage      100%   73.46%   -26.54%     
============================================
  Files            2        5        +3     
  Lines           67      147       +80     
  Branches         8       14        +6     
============================================
+ Hits            67      108       +41     
- Misses           0       39       +39
Impacted Files Coverage Δ
cl_sii/extras/drf_fields.py 0% <0%> (ø)
cl_sii/extras/mm_fields.py 100% <100%> (ø)
cl_sii/extras/dj_model_fields.py 47.5% <47.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba0e1a...bb4ffc3. Read the comment docs.

glarrain added 4 commits April 4, 2019 20:21
"A high-level Python Web framework that encourages rapid development
and clean, pragmatic design."

https://www.djangoproject.com
https://github.com/django/django
"[..] an ORM/ODM/framework-agnostic library for converting complex
datatypes, such as objects, to and from native Python datatypes."

https://marshmallow.readthedocs.io/
https://github.com/marshmallow-code/marshmallow
A separate field class for:

- Django model.
- DRF (Django REST Framework) serializer.
- MM (marshmallow) schema.

Some tests have not been implemented.
@glarrain glarrain force-pushed the feature/add-rut-fields-for-extras branch from 98ad32f to bb4ffc3 Compare April 4, 2019 23:21
@glarrain glarrain merged commit c2595b4 into develop Apr 4, 2019
@glarrain glarrain deleted the feature/add-rut-fields-for-extras branch April 4, 2019 23:39
@glarrain glarrain self-assigned this Apr 4, 2019
@glarrain glarrain mentioned this pull request Apr 5, 2019
@jtrobles-cdd jtrobles-cdd added enhancement New feature or request and removed feature labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: other enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants