Skip to content

Conversation

@fpinto-cdd
Copy link
Contributor

Add code 8020 to file used by schema validator
:func:cte_f29_datos_schema_best_effort_validator,
since this code is currently missing in the tipos
and glosa sections of the F29 file.

Ref: https://cordada.aha.io/requirements/COMPCLDATA-215-1
Ref: https://cordada.aha.io/features/COMPCLDATA-215
Ref: #440

@fpinto-cdd fpinto-cdd added bug Something isn't working component: cte labels Mar 13, 2023
@fpinto-cdd fpinto-cdd requested a review from jtrobles-cdd March 13, 2023 13:24
@fpinto-cdd fpinto-cdd requested a review from a team as a code owner March 13, 2023 13:24
@fpinto-cdd fpinto-cdd self-assigned this Mar 13, 2023
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Mar 13, 2023

Code Climate has analyzed commit 0aad961 and detected 0 issues on this pull request.

View more on Code Climate.

@fpinto-cdd fpinto-cdd force-pushed the bugfix/add-missing-codes-to-file-used-by-best-effort-schema-validator-to-validate-cte-f29-2 branch from ea945db to 9baedea Compare March 13, 2023 13:26
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (09f307f) 85.84% compared to head (0aad961) 85.84%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #458   +/-   ##
========================================
  Coverage    85.84%   85.84%           
========================================
  Files           34       34           
  Lines         2784     2784           
  Branches       356      356           
========================================
  Hits          2390     2390           
  Misses         256      256           
  Partials       138      138           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Add code `8020` to file used by schema validator
:func:`cte_f29_datos_schema_best_effort_validator`,
since this code is currently missing in the `tipos`
and `glosa` sections of the F29 file.

Ref: https://cordada.aha.io/requirements/COMPCLDATA-215-1
Ref: https://cordada.aha.io/features/COMPCLDATA-215
@fpinto-cdd fpinto-cdd force-pushed the bugfix/add-missing-codes-to-file-used-by-best-effort-schema-validator-to-validate-cte-f29-2 branch from 9baedea to 0aad961 Compare March 13, 2023 13:26
@fpinto-cdd fpinto-cdd merged commit 8547d66 into develop Mar 13, 2023
@fpinto-cdd fpinto-cdd deleted the bugfix/add-missing-codes-to-file-used-by-best-effort-schema-validator-to-validate-cte-f29-2 branch March 13, 2023 18:47
This was referenced Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component: cte

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants