Skip to content

fix(cte): Add default values for known missing codes in SII CTE Form 29 #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix(cte): Add default values for known missing codes in SII CTE Form 29 #440

merged 1 commit into from
Mar 9, 2023

Conversation

@fpinto-cdd
Copy link
Contributor

@fpinto-cdd fpinto-cdd commented Feb 27, 2023 •
edited
Loading

  • Add best effort validator that adds default values for missing keys.
  • Add file with default values.
  • Update related test.
  • Update test file.

Ref: https://cordada.aha.io/features/COMPCLDATA-215

@fpinto-cdd fpinto-cdd added bug Something isn't working component: cte labels Feb 27, 2023
@fpinto-cdd fpinto-cdd requested a review from a team as a code owner February 27, 2023 20:46
@fpinto-cdd fpinto-cdd self-assigned this Feb 27, 2023
@fpinto-cdd fpinto-cdd force-pushed the bugfix/fix-errors-creating-sii-cte-form-29 branch 2 times, most recently from d286a8c to 72f935a Compare February 27, 2023 21:36
@fpinto-cdd fpinto-cdd marked this pull request as draft February 27, 2023 21:44
@fpinto-cdd fpinto-cdd force-pushed the bugfix/fix-errors-creating-sii-cte-form-29 branch from 72f935a to d4c337e Compare February 28, 2023 13:09
@fpinto-cdd fpinto-cdd marked this pull request as ready for review February 28, 2023 13:09
@fpinto-cdd fpinto-cdd force-pushed the bugfix/fix-errors-creating-sii-cte-form-29 branch 3 times, most recently from 75a48e5 to 7ded604 Compare February 28, 2023 13:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023 •
edited by codecov bot
Loading

Codecov Report

Patch coverage: 74.28% and project coverage change: -0.06 ⚠️

Comparison is base (dda3e0b) 85.90% compared to head (8326761) 85.84%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #440      +/-   ##
===========================================
- Coverage    85.90%   85.84%   -0.06%     
===========================================
  Files           34       34              
  Lines         2752     2784      +32     
  Branches       350      356       +6     
===========================================
+ Hits          2364     2390      +26     
- Misses         252      256       +4     
- Partials       136      138       +2
Impacted Files Coverage Δ
cl_sii/cte/f29/parse_datos_obj.py 82.29% <74.28%> (-0.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fpinto-cdd fpinto-cdd force-pushed the bugfix/fix-errors-creating-sii-cte-form-29 branch from 7ded604 to 960f42c Compare March 3, 2023 14:10
@fpinto-cdd fpinto-cdd marked this pull request as draft March 6, 2023 20:41
@fpinto-cdd fpinto-cdd force-pushed the bugfix/fix-errors-creating-sii-cte-form-29 branch 3 times, most recently from a98d837 to ba17e3f Compare March 8, 2023 16:22
@jtrobles-cdd
Copy link
Member

jtrobles-cdd commented Mar 8, 2023

@fpinto-cdd Can you add the SII file or files that you used as sources to https://github.com/cl-sii-extraoficial/archivos-oficiales?

@fpinto-cdd fpinto-cdd force-pushed the bugfix/fix-errors-creating-sii-cte-form-29 branch 5 times, most recently from 4b32b6a to a6261e8 Compare March 8, 2023 19:51
@fpinto-cdd fpinto-cdd marked this pull request as ready for review March 8, 2023 19:57
@fpinto-cdd fpinto-cdd force-pushed the bugfix/fix-errors-creating-sii-cte-form-29 branch from a6261e8 to f994045 Compare March 8, 2023 20:11
jtrobles-cdd
jtrobles-cdd requested changes Mar 8, 2023
View reviewed changes
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution! We're almost done.

@fpinto-cdd
fix(cte): Add default values for known missing codes in SII CTE Form 29
8326761 
- Add best effort validator that adds default values for missing keys.
- Add file with default values.
- Update related test.
- Update test file.

Ref: https://cordada.aha.io/features/COMPCLDATA-215
@fpinto-cdd fpinto-cdd force-pushed the bugfix/fix-errors-creating-sii-cte-form-29 branch from f994045 to 8326761 Compare March 9, 2023 13:24
@fpinto-cdd fpinto-cdd requested a review from jtrobles-cdd March 9, 2023 13:25
@fpinto-cdd fpinto-cdd merged commit d03cdd9 into develop Mar 9, 2023
@fpinto-cdd fpinto-cdd deleted the bugfix/fix-errors-creating-sii-cte-form-29 branch March 9, 2023 13:54
@fpinto-cdd fpinto-cdd mentioned this pull request Mar 9, 2023
Merged
@jtrobles-cdd jtrobles-cdd mentioned this pull request Mar 9, 2023
Merged
This was referenced Mar 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtrobles-cdd jtrobles-cdd jtrobles-cdd approved these changes

Assignees

@fpinto-cdd fpinto-cdd

Labels

bug Something isn't working component: cte

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fpinto-cdd @codecov-commenter @jtrobles-cdd