rcv: add module parse_csv
#52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes function `parse_rcv_venta_csv_file`. Tests have not been implemented.
Codecov Report
@@ Coverage Diff @@
## develop #52 +/- ##
===========================================
- Coverage 67.97% 65.23% -2.75%
===========================================
Files 18 19 +1
Lines 840 952 +112
Branches 120 132 +12
===========================================
+ Hits 571 621 +50
- Misses 223 285 +62
Partials 46 46
Continue to review full report at Codecov.
|
Merged
glarrain
added a commit
that referenced
this pull request
May 31, 2019
For parsing all the existing alternatives of an RCV CSV file for "Compra" (purchase), add these functions and their corresponding schemas: - `parse_rcv_compra_registro_csv_file`: "Registro" - `parse_rcv_compra_no_incluir_csv_file`: "No incluir" - `parse_rcv_compra_reclamado_csv_file`: "Reclamado" - `parse_rcv_compra_pendiente_csv_file`: "Pendiente" The implementations are very similar to `parse_rcv_venta_csv_file` (added in PR #52, commit c4fbfc1) and its interface is very different to the old `process_rcv_csv_file` (among other things, instead of calling a given handler on each row it yields the row), which will be removed.
glarrain
added a commit
that referenced
this pull request
May 31, 2019
For parsing all the existing alternatives of an RCV CSV file for "Compra" (purchase), add these functions and their corresponding schemas: - `parse_rcv_compra_registro_csv_file`: "Registro" - `parse_rcv_compra_no_incluir_csv_file`: "No incluir" - `parse_rcv_compra_reclamado_csv_file`: "Reclamado" - `parse_rcv_compra_pendiente_csv_file`: "Pendiente" The implementations are very similar to `parse_rcv_venta_csv_file` (added in PR #52, commit c4fbfc1) and its interface is very different to the old `process_rcv_csv_file` (among other things, instead of calling a given handler on each row it yields the row), which will be removed. Tests have not been implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes function
parse_rcv_venta_csv_file.Tests have not been implemented.