rcv.parse_csv: add parse_rcv_compra_X_csv_file
#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For parsing all the existing alternatives of an RCV CSV file for "Compra" (purchase), add these functions and their corresponding schemas: - `parse_rcv_compra_registro_csv_file`: "Registro" - `parse_rcv_compra_no_incluir_csv_file`: "No incluir" - `parse_rcv_compra_reclamado_csv_file`: "Reclamado" - `parse_rcv_compra_pendiente_csv_file`: "Pendiente" The implementations are very similar to `parse_rcv_venta_csv_file` (added in PR #52, commit c4fbfc1) and its interface is very different to the old `process_rcv_csv_file` (among other things, instead of calling a given handler on each row it yields the row), which will be removed. Tests have not been implemented.
And its related code. Its name was inappropriate because it supported only an specific kind of RCV CSV file: RCV "Compra/Registro" CSV file. Also, the implementation was not very good.
glarrain
force-pushed
the
feature/rcv/add-parse_rcv_compra_X_csv_file
branch
from
0d1af8d to
13a7683
Compare
Contributor
Author
|
CC @glarrai1 |
Codecov Report
@@ Coverage Diff @@
## develop #59 +/- ##
===========================================
+ Coverage 67.54% 67.68% +0.14%
===========================================
Files 20 18 -2
Lines 1026 1046 +20
Branches 154 157 +3
===========================================
+ Hits 693 708 +15
- Misses 286 291 +5
Partials 47 47
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parsing all the existing alternatives of an RCV CSV file for "Compra" (purchase), add these functions and their corresponding schemas:
parse_rcv_compra_registro_csv_file: "Registro"parse_rcv_compra_no_incluir_csv_file: "No incluir"parse_rcv_compra_reclamado_csv_file: "Reclamado"parse_rcv_compra_pendiente_csv_file: "Pendiente"The implementations are very similar to
parse_rcv_venta_csv_file(added in PR #52, commit c4fbfc1) and its interface is very different to the oldprocess_rcv_csv_file(among other things, instead of calling a given handler on each row it yields the row), which will be removed.Removed code:
rcv.process_rcv_csv_file.rcv.parse.