feat(scripts-module): add runParams for factory modules - #98
Merged
Conversation
🦋 Changeset detectedLatest commit: 005e26c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
heymdall-legal
commented
Aug 24, 2023
| RunParams = void, | ||
| ServerState extends BaseModuleState = BaseModuleState, | ||
| > = { | ||
| (serverState: ServerState, runParams: RunParams): ReturnType; |
Collaborator
Author
There was a problem hiding this comment.
Был большой соблазн поменять местами параметры у этих модулей, чтобы они были более похоже на moutable, но это был бы breaking change, а не хочется ломать api если его кто-то уже использует. Но если использования еще нет - то можно бы и поломать без поднятия мажорки
Collaborator
There was a problem hiding this comment.
Давай поменяем. С учётом того, что с вероятностью 99.9% мы пока единственные потребители, нам не сложно будет подстроиться
vaagnavanesyan
approved these changes
Aug 28, 2023
chermashentsau
approved these changes
Aug 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавлено описание типов для Factory-модулей, доступно как
FactoryModule.Factory-модули теперь могут принимать
runParams- отдельный параметр, который не будет передаваться на сервер, асразу будет попадать из клиента в клиент.
Mountable модули теперь могут использовать запись вида
export default mountableModule;вместо отдельных экспортовmountиunmountфункций.