net.c: switch strncat(3) use to strlcat(3)#156
Open
ngie-eign wants to merge 2 commits into
Open
Conversation
This will be leveraged in the next commit, resolving complaints from compilers about the pathological case where strncat(3) is used in net.c . Obtained from: (DragonFlyBSD.org: lib/libc/string/strlcpy.c @ 667231f1) Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
Contributor
Author
|
@ckujau: FYI. |
strlcat(3), unlike its predecessor (strncat(3)), NUL terminates buffers when the buffer length meets or exceeds the provided `dstsize`. Leveraging strlcat(3) instead of strncat(3) squashes compiler warnings, and ensures the buffer is properly NUL terminated in the pathological case. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strlcat(3), unlike its predecessor (strncat(3)), NUL terminates buffers
when the buffer length meets or exceeds the provided
dstsize.Leveraging strlcat(3) instead of strncat(3) squashes compiler warnings,
and ensures the buffer is properly NUL terminated in the pathological case.
This is an alternative approach to the solution suggested in #77.