Icon (symbolics) theming#411
Merged
corecoding merged 15 commits intocorecoding:developfrom Mar 8, 2024
Merged
Conversation
due to the newly addition of the 'icon style' combo box the symmetry on the 'about' section got broken, this commit fixes this issue by having a dedicated row to the 'about' section
included credits for the new icon theme
Contributor
|
I would suggest naming the new theme "Adwaita" or "GNOME", since later on other icon themes could be added |
Contributor
Author
Done! Changed the new theme name from |
daudix
reviewed
Mar 5, 2024
corecoding
approved these changes
Mar 8, 2024
Owner
|
Thank you, this is great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request continues the idea of #295 and aims to implement the feature exposed on #295 (comment) by @corecoding by adding an icon theme switcher in the preference's menu.
Changes to the UI
The icon theme switcher is made out of a combo box on the general section of the preference's menu, and, as it is, includes two themes to choose from,
originalandgnome. The icons fromoriginalare the current theme and the icons fromgnomeare the icons proposed by @daudix in #295.Some changes to the layout had to be made, in specific, the section "About", with the addition of the new combo box would lose alignment with the section "Sensors", so I took the freedom to move it to the bottom. Another improvement to the UI is the definition of
margin-endto all switch components, so that they wouldn't be touching theGtkBoxright limit.Note: Currently, the
gnometheme includes the samegpusymbolic icon as theoriginaltheme. If this PR gets merged, I would ask @daudix for an updated version since he is the one responsible for the theme (🥺).Changes to
/iconsIn order to have multiple themes, each theme is now represented as a new folder on the
Vitals/iconsdirectory and the name of the icons SVG included on a theme must match the names of theoriginaltheme. In this pull request we have the/originaland/gnomefolders, each representing a theme.Adding a new theme
To add a new icon theme:
/iconswith the new symbolics;prefs.ui;_sensorsIconPathPrefixvariable inextension.js;Note that on step
3., the index of each theme's prefix on the_sensorsIconPathPrefixvariable must match the index of the combo box item defined atprefs.ui. For example, if on the combo box theoriginaltheme is the first item (index 0) then it must be the first on the list of prefixes.README Updates
Updated the README.md file to include the credits for the newly added theme.