Skip to content

deps: drop golang-github-aliyun-cli#4601

Merged
c4rt0 merged 1 commit into
coreos:mainfrom
c4rt0:apiaseck/dropAliyun
Jul 23, 2026
Merged

deps: drop golang-github-aliyun-cli#4601
c4rt0 merged 1 commit into
coreos:mainfrom
c4rt0:apiaseck/dropAliyun

Conversation

@c4rt0

@c4rt0 c4rt0 commented Jul 23, 2026

Copy link
Copy Markdown
Member

The package was orphaned in F44, the build succeeds without it.

See: #4572

Summary by CodeRabbit

  • Chores
    • Updated the declared AWS/HTTP package requirements to align with the current runtime needs.
    • Removed an unused Aliyun command-line dependency from the packaged dependencies list.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a80cff2b-92e2-4b91-a31f-a60adc7abe05

📥 Commits

Reviewing files that changed from the base of the PR and between 77ed6dd and 5f3df8f.

📒 Files selected for processing (2)
  • rpms.in.yaml
  • src/deps.txt
💤 Files with no reviewable changes (1)
  • rpms.in.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/deps.txt

📝 Walkthrough

Walkthrough

The AWS/HTTP dependency declarations remove golang-github-aliyun-cli, update the section label, and retain the boto3 and requests dependencies.

Changes

AWS/HTTP dependency cleanup

Layer / File(s) Summary
Update AWS/HTTP dependencies
src/deps.txt, rpms.in.yaml
The AWS/HTTP section is relabeled, and golang-github-aliyun-cli is removed from both dependency declarations while python3-boto3 and python3-requests remain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely states the main change: removing golang-github-aliyun-cli.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/deps.txt`:
- Around line 42-43: Remove the Aliyun CLI dependency from the complete
dependency graph: delete its entry from the RPM manifest and regenerate the
lockfile so the corresponding pinned package is absent, while preserving the
remaining dependencies in src/deps.txt.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 22f75568-c08c-439f-97ab-bc9c5333d648

📥 Commits

Reviewing files that changed from the base of the PR and between 14cf32d and 77ed6dd.

📒 Files selected for processing (1)
  • src/deps.txt

Comment thread src/deps.txt
The package was orphaned in F44, the build succeeds without it.
@c4rt0
c4rt0 force-pushed the apiaseck/dropAliyun branch from 77ed6dd to 5f3df8f Compare July 23, 2026 16:23
@c4rt0

c4rt0 commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

/retest

@dustymabe dustymabe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@c4rt0
c4rt0 merged commit c57b48a into coreos:main Jul 23, 2026
9 checks passed
@c4rt0
c4rt0 deleted the apiaseck/dropAliyun branch July 24, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants