This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: Allow a custom SSH port#1148
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Why is this not exported like the rest of the fields of this struct?
Contributor
|
Please squash all your commits down to one |
Author
|
@bcwaldon thanks! updated |
Contributor
There was a problem hiding this comment.
Per golang formatting guidelines, acronyms should be capitalized. Make this SSHPort.
Contributor
|
@hhoover the commit message isn't really providing a lot of value. Drop everything from |
Author
|
@bcwaldon done! |
Contributor
|
@hhoover looks like this code is a little broken. Can you run the tests locally? |
This allows end users to specify a custom SSH port with fleetctl when connecting to machines.
Author
|
@bcwaldon tests passed! |
Contributor
|
LGTM - Thanks @hhoover |
bcwaldon
added a commit
that referenced
this pull request
Apr 7, 2015
fleetctl: Allow a custom SSH port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows end users to specify a custom SSH port with fleetctl when connecting to machines.
This is code that was split out from PR #961 by @ryandub