This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: Add ssh-port info to ssh runCommand func#1178
Merged
Conversation
Add ssh-port context to ssh.go's runCommand so that the address + port is combined with findSSHPort and passed to runRemoteCommand. This commit allows ssh-port to function as expected.
Contributor
|
LGTM |
bcwaldon
added a commit
that referenced
this pull request
Apr 10, 2015
fleetctl: Add ssh-port info to ssh runCommand func
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1148 added in the
ssh-portflag to fleetctl (thanks @hhoover !!). However, there was a slight omission inssh.goto add the port context torunCommand. This adds that info so that--ssh-portworks as expected.