Reconcile commands with the current API client signatures#7
Merged
Conversation
The regenerated client moved feedSummary and issuesTimelineList to positional workspaceId/id arguments and made acceptTerms required on workspace creation, so CI's fresh codegen broke typecheck on main. Workspace create passes acceptTerms via a non-literal assignment: creating a workspace from the CLI implies accepting the terms (same as the console flow), and the indirection keeps typecheck green against spec versions from before the field existed — the CI environment's spec (317 operations) doesn't have it yet while prod (326) requires it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Workspace creation sends acceptTerms on the user's behalf; the CLI now says so before the call, with the terms URL, on stderr per the stdout/stderr contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main's CI is red: the
Generate client from OpenAPI specstep now produces signatures the command code predates. This is spec drift, not a regression from #6 — the same failure occurs on any branch.feedSummaryandissuesTimelineListtake positionalworkspaceId/idnow; calls updated.workspacesPostrequiresacceptTerms: trueon the prod spec (326 operations) but not yet on the CI environment's spec (317). The value is passed through a non-literal assignment so typecheck stays green against both. Semantics: creating a workspace from the CLI implies accepting the terms, matching the console flow — flag if you'd rather surface an explicit--accept-termsprompt instead.Test plan
npm run typecheckclean against a fresh prod-spec codegennpm test117/117, lint clean, build cleanWorth checking separately: the CI
POLYLANE_API_DOMAINsecret points at an API nine operations behind prod, so CI typechecks against a stale surface.🤖 Generated with Claude Code