chore: ignore node_modules in every directory, not just the root - #628
Merged
Conversation
The docs are a standalone project, so their dependencies land in docs/node_modules — which the anchored pattern did not cover, leaving them untracked in git status and one 'git add -A' away from being committed.
Coverage Report for CI Build 30265656780Coverage increased (+0.02%) to 94.643%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignoreanchors the pattern at the repository root:The docs are a standalone project, not a workspace of the root, so
npm installthere createsdocs/node_modules— which that pattern does not cover. It shows up as untracked ingit statusand is onegit add -Aaway from being committed to a public repository.Nothing has ever been committed there, so this only closes the hole. Unanchoring the pattern also covers any future nested project.
The same applies to
coreui(free), where the pattern is identical.