Fix concat() path mangling on Windows - #13
Merged
Conversation
The concat demuxer treats backslash as an escape character inside a quoted path, so a Windows path like C:\Users\... written verbatim into the list file gets mangled. Translate to forward slashes (ffmpeg accepts them on Windows), matching what .subtitles_filter() already does. Also fixes render_timeline()'s stream-copy path, which routes through concat().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-slash paths in the concat demuxer list file so Windows paths aren't mangled by ffmpeg's backslash escaping. Also fixes render_timeline()'s stream-copy path, which routes through concat(). No new dependency, no API change. All 81 tests pass. Version bump 0.1.0.6 -> 0.1.0.7.