fix Num multiplication, add Real, Enum, Integral instances#67
Merged
CetinSert merged 1 commit intocorsis:masterfrom Jul 13, 2021
Merged
fix Num multiplication, add Real, Enum, Integral instances#67CetinSert merged 1 commit intocorsis:masterfrom
CetinSert merged 1 commit intocorsis:masterfrom
Conversation
These instances are based on using the nanosecond as the underlying unit, i.e. the value of a TimeSpec is the integer s * 1e9 + ns. Before it was based on representing the rational s + (ns / 1e9). But the integer valuation satisfies the ring laws and provides much more intuitive behavior, e.g. (2 :: TimeSpec)*(2 :: TimeSpec) = (4 :: TimeSpec) Before, this gave 0.
|
This change broke our program. I blame ourselves for multiplying two TimeSpecs together in the first place (no one was after seconds-squared). But this is a breaking change and probably should have at least made it to the changelog |
Contributor
Author
|
Well, it is in the changelog, somewhat vaguely, as "TODO: new module System.Clock.Seconds" and following. I think the more pressing issue is that per https://pvp.haskell.org/ the changes should have caused a major version bump, so the release should be 0.9.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These instances are based on using the nanosecond as the underlying unit, i.e. the value of a TimeSpec is the integer
s * 1e9 + ns.Before it was based on representing the rational
s + (ns / 1e9). But the integer valuation satisfies the ring laws and provides much more intuitive behavior, e.g.Before, this gave 0.
This should properly fix #32, #33. Of course it breaks anyone who was using the old version of
(*). The old version of(*)is equivalent toa * b `div` 1000000000in the new version.