Skip to content

Lower case nits and clean up cluster uninstall #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2019
Merged

Lower case nits and clean up cluster uninstall #599

merged 1 commit into from
Nov 25, 2019

Conversation

@vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Nov 25, 2019

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cortex deploy --refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu November 25, 2019 22:40
@vishalbollu vishalbollu merged commit 41ddd8a into master Nov 25, 2019
@vishalbollu vishalbollu deleted the lowercase-nits-other-tweaks branch November 25, 2019 22:44
vishalbollu added a commit that referenced this pull request Nov 25, 2019
@vishalbollu
Lower case nits and clean up cluster uninstall (#599)
11bf358 
(cherry picked from commit 41ddd8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu deliahu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vishalbollu @deliahu