Skip to content

Fix memory leak caused by object pool and zero copy #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bboreham merged 2 commits into from
Jul 7, 2020
Merged

Fix memory leak caused by object pool and zero copy #2839

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeff9c3
Fix memory leak caused by object pool and zero copy
storyicon Jul 6, 2020
819f1a9
add some comments
storyicon Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/ingester/client/timeseries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,11 @@ func ReuseSlice(ts []PreallocTimeseries) {

// ReuseTimeseries puts the timeseries back into a sync.Pool for reuse.
func ReuseTimeseries(ts *TimeSeries) {
// Name and Value may point into a large gRPC buffer, so clear the reference to allow GC
for i := 0; i < len(ts.Labels); i++ {
ts.Labels[i].Name = ""
Copy link
Copy Markdown
Contributor

@bboreham bboreham Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest // Name and Value may point into a large gRPC buffer, so clear the reference to allow GC

Copy link
Copy Markdown
Contributor Author

@storyicon storyicon Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accepted your suggestion, thanks!

ts.Labels[i].Value = ""
}
ts.Labels = ts.Labels[:0]
ts.Samples = ts.Samples[:0]
timeSeriesPool.Put(ts)
Expand Down