Support Bazel 0.5.3#531
Conversation
Works around issue with Bazel BUILD files.
Generated with `make update-gazelle`
|
|
||
| # bazel build does not work with earlier versions: | ||
| # | ||
| # ERROR: /Users/jml/go/src/github.com/weaveworks/cortex/vendor/github.com/weaveworks-experiments/loki/pkg/client/BUILD.bazel:3:1: no such package 'vendor/github.com/openzipkin/zipkin-go-opentracing/_thrift/gen-go/zipkincore': BUILD file not found on package path and referenced by '//vendor/github.com/weaveworks-experiments/loki/pkg/client:go_default_library'. |
There was a problem hiding this comment.
Have you got an up to date version of gazelle?
|
Forgot to test last two commits with |
|
I'm +1 on explicit dependancies and +1 on the version upgrades, but -1 on the override. Let me know when you get it working and I'll take another look. When you want to build this in CI (and want to build the protos with bazel) give me a shout, as I have a branch that already does it somewhere. |
|
Thanks. I'll look into it. Why are you against the override? |
|
Why are you against the override?
It should be unnecessary with the latest gazelle, unless I'm missing
something.
…On Tue, Aug 8, 2017 at 12:54 PM Jonathan Lange ***@***.***> wrote:
Thanks. I'll look into it. Why are you against the override?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#531 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbGhdwQjfs4bZis1dgWnotdWYJ74oyRks5sWEyDgaJpZM4Oubr4>
.
|
|
I haven't forgotten this. I'm just on a tight deadline with some other project work. (I did this on an unusually free weekend against my better judgement).
@tomwilkie Could you please point me at that? I would like to do that shortly after merging this. |
|
Closed in favour of #557 |
2 participants
It's out, and it has improved cross-compilation support.
Getting this to work was a bit of a saga. See #530 for the gruesome details. In terms of meaningful changes:
*.pb.gofiles in the relevant make targets, so we get proper gazelle files, and so the build passesHaven't actually tried cross-compiling.