Conversation
Remove tracing and metrics plumbing from the store and app build paths: drop traceStore parameters and SetCommitMultiStoreTracer calls (NewSimApp, newTestnetApp, AppBuilder.Build, runtime Build, etc.), remove store tracing APIs (SetTracer, TracingEnabled, TraceContext, related fields) and remove metrics arguments from store/IAVL loaders and constructors (NewStore, LoadStore, LoadStoreWithInitialVersion, LoadStoreWithOpts). Update documentation to reflect several module and API changes: mark x/crisis moved to contrib, x/nft moved to contrib, x/group moved to Enterprise, expand x/consensus README, add distribution CLI/grpc query examples, add mint MaxSupply notes, add gov hooks and voting-power API changes, and tidy events/store docs to remove deprecated tracing references. These changes simplify the codebase by removing legacy tracing/metrics integrations and update docs for module relocations and API evolutions.
Greptile SummaryThis PR updates the Key changes:
Notable issues:
Confidence Score: 4/5
Important Files Changed
|
| ``` | ||
|
|
||
| See the [Log Overview](/sdk/next/learn/advanced/log) for more information on logging. | ||
|
|
There was a problem hiding this comment.
Potentially broken link to non-existent page
The link /sdk/next/learn/advanced/log does not appear to exist in this repository. None of the 26 changed files include a log.mdx, and a search of the repo does not surface it. The PR description notes that changelog item #25778 was supposed to add an upgrade guide entry referencing log.mdx, but migrations/upgrade-guide.mdx was not included in this PR's diff. If the log overview page hasn't been created yet, this link will be a 404 for users.
Consider either:
- Replacing the link with a reference to the existing logging section in
run-node.mdxitself until the dedicated page is created, or - Removing the "See…" sentence until
log.mdxlands.
There was a problem hiding this comment.
It should be in the repo: https://github.com/cosmos/docs/blob/v54-updates/sdk/next/learn/advanced/log.mdx
| <Warning> | ||
| The `x/group` module is now maintained under the Cosmos Enterprise offering. If your application uses `x/group`, you will need to migrate your code to the Enterprise-distributed package and obtain a Cosmos Enterprise license to continue using it. Please see [Cosmos Enterprise](/enterprise/overview) to learn more. | ||
| </Warning> | ||
|
|
There was a problem hiding this comment.
No guidance for open-source users
The warning tells users that x/group now requires a Cosmos Enterprise license, but doesn't mention what open-source users who can't obtain that license should do. Many projects relied on x/group for multisig governance. Consider adding a sentence such as: "If you are unable to obtain a Cosmos Enterprise license, the module source is still available in the SDK repo history and you may fork and self-maintain it."
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This PR updates the
/nextdocumentation to reflect all breaking changes, new features, and improvements in the upcoming Cosmos SDK v0.54 release, based on the unreleased CHANGELOG.cometbft/next/spec/core/genesis.mdx,cometbft/next/spec/abci/Requirements-for-the-Application.mdx,sdk/next/learn/beginner/accounts.mdxsr25519withbls12381in key type referencesmodules/nft/README.mdx,modules/circuit/README.mdx,modules/crisis/README.mdx,building-modules/invariants.mdx,migrations/upgrade-guide.mdxmodules/group/README.mdx,migrations/upgrade-guide.mdxmodules/gov/README.mdx,migrations/upgrade-guide.mdxBondedTokens→ValidatorPower,CalculateVoteResultsAndVotingPowerFnrequired,DistrKeeperoptional,AfterProposalSubmissionhook updatedmodules/mint/README.mdxMaxSupplyparameter; updated CLI/gRPC example outputsmodules/staking/README.mdxMsgUpdateParamsmigrations/upgrade-guide.mdxlearn/advanced/store.mdx,build/spec/store/store.mdx,building-apps/app-go.mdx,building-apps/runtime.mdx,building-apps/app-testnet.mdx,build/abci/checktx.mdxSetTracer,SetTracingContext,TracingEnabled,CacheWrapWithTrace,SetMetrics,StoreMetrics, and alltraceStore io.Writerparamsbuilding-modules/depinject.mdx,building-apps/app-go-di.mdxlearn/advanced/events.mdx,building-modules/msg-services.mdxlearn/advanced/grpc_rest.mdxhistorical-grpc-address-block-rangeconfig documentation--verbose_log_levelflaguser/run-node/run-node.mdxmodules/distribution/README.mdxValidatorHistoricalRewards,ValidatorCurrentRewards,DelegatorStartingInfomodules/consensus/README.mdxMsgUpdateParams,AuthorityParamsfeature, CLI/gRPC/RESTlearn/advanced/grpc_rest.mdxGetBlockResults/GetLatestBlockResultslearn/advanced/events.mdxOverrideEventsmethod