Skip to content

Conversation

@cloudgray
Copy link
Contributor

Description

Closes: #833

Done

  • replace Erc20Keeper dependency from other module tests
  • replace FeeMarketKeeper dependency from other module tests

Limitation

  • In case of ibc, bank tests, erc20 keeper is closely dependent. So, currently, it is hard to remove dependencies.
  • In case of some of x/vm module tests, feemarket keeper is closely dependent. So, currently, it is hard to remove dependencies.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.22%. Comparing base (381a354) to head (a897992).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
+ Coverage   65.19%   65.22%   +0.03%     
==========================================
  Files         317      317              
  Lines       21612    21612              
==========================================
+ Hits        14090    14097       +7     
+ Misses       6358     6352       -6     
+ Partials     1164     1163       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudgray cloudgray marked this pull request as ready for review November 17, 2025 02:01
@aljo242 aljo242 added this pull request to the merge queue Nov 17, 2025
Merged via the queue into cosmos:main with commit 1cc187c Nov 17, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor tests not to use unncessary keeper methods

2 participants