fix: Fix err ack in ibc v2 middleware#967
Merged
Eric-Warehime merged 6 commits intomainfrom Feb 6, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
==========================================
+ Coverage 65.56% 65.62% +0.06%
==========================================
Files 319 319
Lines 22220 22225 +5
==========================================
+ Hits 14569 14586 +17
+ Misses 6480 6476 -4
+ Partials 1171 1163 -8
🚀 New features to boost your workflow:
|
vladjdk
approved these changes
Jan 30, 2026
srdtrk
approved these changes
Feb 2, 2026
Member
srdtrk
left a comment
There was a problem hiding this comment.
Lgtm. Left a hardening suggestion, I'll leave it up to you to implement it or not. I can verify that this fixes the original issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the err ack return value in the ibc v2 middleware for erc20s.
Previously we were swallowing the return value of the keeper invocation. After this change we properly return an error ack if the app's
OnRecvPacketcall passes, but the middleware keeper'sOnRecvPacketcall fails.Adde test covers this case.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch