Skip to content

fix: gas config is set to zero in ibc transfer keeper#968

Merged
aljo242 merged 8 commits intocosmos:mainfrom
yihuang:fix-gas
Feb 18, 2026
Merged

fix: gas config is set to zero in ibc transfer keeper#968
aljo242 merged 8 commits intocosmos:mainfrom
yihuang:fix-gas

Conversation

@yihuang
Copy link
Copy Markdown
Collaborator

@yihuang yihuang commented Feb 2, 2026

Description

Solution:

  • it's better to be safe unless there's good reason for that.

Closes: #969


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Solution:
- it's better to be safe unless there's good reason to do that.
Comment thread CHANGELOG.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.60%. Comparing base (1651ab9) to head (58c276f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
- Coverage   65.62%   65.60%   -0.02%     
==========================================
  Files         319      319              
  Lines       22201    22188      -13     
==========================================
- Hits        14569    14557      -12     
  Misses       6483     6483              
+ Partials     1149     1148       -1     
Files with missing lines Coverage Δ
x/erc20/keeper/ibc_callbacks.go 93.04% <ø> (-0.18%) ⬇️
x/ibc/transfer/keeper/msg_server.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aljo242 aljo242 changed the title Problem: gas config is set to zero in ibc transfer keeper fix: gas config is set to zero in ibc transfer keeper Feb 2, 2026
Copy link
Copy Markdown
Member

@vladjdk vladjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this change - there should not be free gas on any action taken on the EVM.

@aljo242 aljo242 enabled auto-merge February 18, 2026 20:54
@aljo242 aljo242 added this pull request to the merge queue Feb 18, 2026
Merged via the queue into cosmos:main with commit 1fa87d9 Feb 18, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem: ibc transfer keeper set zero gas config

3 participants