Skip to content

Conversation

@johnnylarner
Copy link
Contributor

Description

Removed all legacy param references. Legacy files contain key values as bytes that were referenced. I moved these into the params file.

These changes only affect how we internally build our simapps. The NewKeeper remains unchanged and therefore I do not see the need to include this in the CHANGELOG. We may want to classify as a chore in that case.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

@linear
Copy link

linear bot commented Jun 6, 2025

@johnnylarner johnnylarner marked this pull request as draft June 6, 2025 13:57
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.97%. Comparing base (da79ea8) to head (f590625).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
modules/apps/callbacks/testing/simapp/app.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8493      +/-   ##
==========================================
+ Coverage   56.80%   56.97%   +0.17%     
==========================================
  Files         296      291       -5     
  Lines       21431    21336      -95     
==========================================
- Hits        12174    12157      -17     
+ Misses       8707     8629      -78     
  Partials      550      550              
Flag Coverage Δ
08-wasm 66.13% <ø> (ø)
e2e 1.18% <ø> (ø)
ibc-go 62.45% <0.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnnylarner johnnylarner marked this pull request as ready for review June 6, 2025 14:03
@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Jun 8, 2025

I noticed that the genesis e2e test was failing, and when I started looking a bit deeper, I realized we could actually safely remove x/params entirely from our simapps.
The usage of the subspaces in the SDK modules were only for migration purposes, and we don't need that for our simapps.
Commit for this: 4179957

The only place that I've left any usage of params left is in our e2e tests, and that is only because it is needed for compatibility tests (where we spin up older versions). We will eventually be able to get rid of those too, but we need to at a minimum get rid of ibc-go v7 first (which might take some time still).

Edit: Sorry, I didn't mean to take over this PR, but I really wanted to get this merged, so I took the liberty of fixing one more thing I had missed in my initial review, which was that the param keys should be in the keys.go files rather than in the params.go file.
You can see the commit here: d964eef

@gjermundgaraba gjermundgaraba changed the title Johnnylarner/ibcgo 2352 remove all remaining legacy params code chore: remove all internal uses of legacy params Jun 8, 2025
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🙌 This cleans up the codebase in a very real way 🎉

I left a comment on some updates I did to the PR, sorry for taking over a bit here at the end, I just wanted to get this merged in to test with some other changes :)

@gjermundgaraba gjermundgaraba merged commit ec80456 into main Jun 8, 2025
50 of 51 checks passed
@gjermundgaraba gjermundgaraba deleted the johnnylarner/ibcgo-2352-remove-all-remaining-legacy-params-code branch June 8, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants