-
Notifications
You must be signed in to change notification settings - Fork 734
chore: remove all internal uses of legacy params #8493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove all internal uses of legacy params #8493
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8493 +/- ##
==========================================
+ Coverage 56.80% 56.97% +0.17%
==========================================
Files 296 291 -5
Lines 21431 21336 -95
==========================================
- Hits 12174 12157 -17
+ Misses 8707 8629 -78
Partials 550 550
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I noticed that the genesis e2e test was failing, and when I started looking a bit deeper, I realized we could actually safely remove x/params entirely from our simapps. The only place that I've left any usage of params left is in our e2e tests, and that is only because it is needed for compatibility tests (where we spin up older versions). We will eventually be able to get rid of those too, but we need to at a minimum get rid of ibc-go v7 first (which might take some time still). Edit: Sorry, I didn't mean to take over this PR, but I really wanted to get this merged, so I took the liberty of fixing one more thing I had missed in my initial review, which was that the param keys should be in the keys.go files rather than in the params.go file. |
…-legacy-params-code
…-legacy-params-code
…-legacy-params-code
…-legacy-params-code
gjermundgaraba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🙌 This cleans up the codebase in a very real way 🎉
I left a comment on some updates I did to the PR, sorry for taking over a bit here at the end, I just wanted to get this merged in to test with some other changes :)
…-legacy-params-code
Description
Removed all legacy param references. Legacy files contain key values as bytes that were referenced. I moved these into the params file.
These changes only affect how we internally build our simapps. The
NewKeeperremains unchanged and therefore I do not see the need to include this in the CHANGELOG. We may want to classify as a chore in that case.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.