docs(phi-scan): cut a test-composition sentence that was wrong twice - #39
Merged
Merged
Conversation
The third conformance pass on the phi-scan slice found that the sentence describing which tests stay green under the base scanner under-enumerates: it named "the floor tests, the controls, and the ones that PIN a residual", and at least 15 of the 38 fall in none of those categories. They are regression guards from earlier slices: rename detection, staged non-regular entries, all-mode non-regular entries, and the two invocation-failure cases. This repo's own vocabulary makes "controls" a narrow enumerated set, so they cannot be absorbed into it. That paragraph has now produced a documentation-accuracy defect on three consecutive passes, which is a signal about the paragraph rather than about the scanner. So the sentence is CUT rather than restated a fourth time, per this repo's standing "CUT, do not rewrite" rule. What replaces it is the one fact that is cheap to verify and does not decay into a taxonomy: 33 of the 38 are tests the base suite already carried, re-derived here (34 base tests, 33 carried forward, 14 new, 47 total). The load-bearing number is untouched and was confirmed by the same pass: 9 of 47 red against cd221a0's scanner. No behaviour changes; this is one markdown paragraph. A sibling instance of the same pattern one section up, describing an earlier slice's comparison, is PRE-EXISTING and is deliberately left alone for its own slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #38, from its third conformance pass.
The sentence describing which tests stay green under the base scanner under-enumerated: it named "the floor tests, the controls, and the ones that PIN a residual", and at least 15 of the 38 fall in none of those categories. They are regression guards from earlier slices (rename detection, staged non-regular entries, all-mode non-regular entries, and the two invocation-failure cases), and this repo's vocabulary makes "controls" a narrow enumerated set that cannot absorb them.
That paragraph produced a documentation-accuracy defect on three consecutive passes, which is a signal about the paragraph rather than the scanner. The sentence is therefore cut rather than restated a fourth time, per the standing "CUT, do not rewrite" rule. What replaces it is the one fact that is cheap to verify and does not decay into a taxonomy: 33 of the 38 are tests the base suite already carried, re-derived here (34 base tests, 33 carried forward, 14 new, 47 total).
The load-bearing number is untouched and was confirmed by that same pass: 9 of 47 red against
cd221a0's scanner. One markdown paragraph, no behaviour change.A sibling instance of the same pattern one section up, describing an earlier slice, is
PRE-EXISTINGand is deliberately left for its own slice.