Skip to content

Conversation

@rakeshAlgo
Copy link
Contributor

Hi @amarantha-k ,
I have fixed a few vertical space issues for the list, paragraph, and definition list in the table.

@rakeshAlgo
Copy link
Contributor Author

Hi @amarantha-k ,
Today I have fixed some Mobile issues and also fixed tutorial landing page dropdown button is not working on live site.

@amarantha-k amarantha-k requested a review from mojavelinux July 20, 2020 17:09
src/css/base.css Outdated
background-color: #0074e00e;
font-size: var(--font-small);
/* font-size: var(--font-small); */
font-size: inherit;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font size is going to inherit by default, so as long as you remove the explicit override, it will just work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed to address code font in headings, paragraphs, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because the font size is being set in src/css/base.css. If you don't want the font size to be different than the font size of the parent element, it's best just to remove this altogether. That way you don't need to override it in multiple places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mojavelinux ,
Thanks for the clarification, Now I removed font size from code.

@amarantha-k amarantha-k requested a review from mojavelinux July 22, 2020 13:26
@amarantha-k amarantha-k merged commit 01b3080 into master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants