-
Notifications
You must be signed in to change notification settings - Fork 21
UI issues fixes for image block paragraph and table definition list #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @amarantha-k , |
src/css/base.css
Outdated
| background-color: #0074e00e; | ||
| font-size: var(--font-small); | ||
| /* font-size: var(--font-small); */ | ||
| font-size: inherit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font size is going to inherit by default, so as long as you remove the explicit override, it will just work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed to address code font in headings, paragraphs, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because the font size is being set in src/css/base.css. If you don't want the font size to be different than the font size of the parent element, it's best just to remove this altogether. That way you don't need to override it in multiple places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mojavelinux ,
Thanks for the clarification, Now I removed font size from code.
Hi @amarantha-k ,
I have fixed a few vertical space issues for the list, paragraph, and definition list in the table.