Skip to content

UI issues fixes for image block paragraph and table definition list #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amarantha-k merged 8 commits into from
Jul 24, 2020
Merged

UI issues fixes for image block paragraph and table definition list #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2a14835
UI issues fixes for image block paragraph and table difinition list …
Jul 10, 2020
63be8f8
Merge branch 'master' of https://github.com/couchbase/docs-ui-sandbox…
bindaasrakesh Jul 13, 2020
c4e45e1
Regression testing on live site and fixes the bug for landing page an…
bindaasrakesh Jul 13, 2020
2876111
Fix font size for code tag & table heading
bindaasrakesh Jul 14, 2020
0c408bf
Merge branch 'master' of https://github.com/couchbase/docs-ui-sandbox…
bindaasrakesh Jul 14, 2020
b5c12eb
Fix responsive image and video spacing issues
bindaasrakesh Jul 17, 2020
4321675
Fix mobile menu overlap with left menu and footer content
bindaasrakesh Jul 20, 2020
7eeebef
Remove font size from code block
rakeshAlgo Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ pre {

code {
background-color: #0074e00e;
font-size: var(--font-small);
word-spacing: -0.125em;
color: var(--color-brand-gray1);
}
Expand Down
28 changes: 26 additions & 2 deletions src/css/doc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,18 @@ ul ul ul {
border-top-width: 1px;
}

.ulist li .paragraph:first-child,
.olist li .paragraph:first-child,
.dlist li .paragraph:first-child {
margin-top: var(--base-extra-small-space);
}

.ulist li .imageblock,
.olist li .imageblock,
.dlist li .imageblock {
margin-bottom: var(--base-extra-small-space);
}

/* .doc table.tableblock,
.doc th.tableblock,
.doc td.tableblock {
Expand Down Expand Up @@ -418,7 +430,7 @@ ul ul ul {
}

.doc .imageblock img {
display: block;
display: inline-block;
}

.doc .imageblock .title {
Expand Down Expand Up @@ -460,7 +472,7 @@ ul ul ul {
margin-top: var(--base-extra-large-space);
}

.doc .abstract blockquote * {
.doc blockquote * {
font-weight: inherit;
}
/* .doc .abstract blockquote::before {
Expand Down Expand Up @@ -539,6 +551,10 @@ ul ul ul {
margin: 0;
}

.hdlist table .hdlist1 + .hdlist2 p {
margin-left: var(--base-space);
}

.doc pre:not(.highlight),
.doc pre.highlight code {
/* background-color: #151514; */
Expand Down Expand Up @@ -1095,4 +1111,12 @@ table.tableblock pre code.language-bash.hljs {
.doc h6 > a.anchor {
font-size: 18px;
}

.card-row .column .content .imageblock {
text-align: center;
}

main {
padding-bottom: 2rem;
}
}
9 changes: 8 additions & 1 deletion src/css/header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
.navbar-new-top {
.header-top-row {
background: var(--color-brand-white);
padding: 0 var(--width-container-gutter);
}

.header-top-row .container {
padding-left: 0;
padding-right: 0;
}

.navbar-brand img {
Expand Down Expand Up @@ -305,5 +311,6 @@
display: block;
position: absolute;
width: 100%;
left: 0;
}
}
2 changes: 2 additions & 0 deletions src/css/landing-page.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,8 @@

.doc.landing-page-doc .media-left {
margin-left: 0;
padding-left: 0;
text-align: center;
}

.doc.landing-page-doc figure {
Expand Down
2 changes: 1 addition & 1 deletion src/css/nav.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
scrollbar-width: thin;
scrollbar-color: var(--color-border) transparent;
height: 100%;
z-index: var(--z-index-nav);
z-index: 5;
transition: all 0.1s;
}

Expand Down
8 changes: 6 additions & 2 deletions src/css/table.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,15 @@ table.tableblock thead th {
padding-bottom: var(--base-space);
text-align: left;
border-bottom: 2px solid var(--color-brand-blue-secondary);
font-size: 1rem;
line-height: 1.25rem;
font-size: 1.125rem;
line-height: 1.5rem;
font-weight: var(--weight-semibold);
}

/* table.tableblock tbody td:first-child strong {
font-size: 1.125rem;
} */

table.tableblock tbody tr {
display: table-cell;
}
Expand Down
12 changes: 6 additions & 6 deletions src/js/01-nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,14 @@
function concealEvent (e) {
e.stopPropagation()
}

// scroll left menu to current active page

var currentPageMenu = document.querySelector('.is-current-page')
var topPositon = currentPageMenu.offsetTop
var leftMenu = document.querySelector('.left-sidebar-menu .nav-menu')
setTimeout(function () {
leftMenu.scrollTop = topPositon
if (document.querySelector('.is-current-page')) {
var currentPageMenu = document.querySelector('.is-current-page')
var topPositon = currentPageMenu.offsetTop
var leftMenu = document.querySelector('.left-sidebar-menu .nav-menu')
leftMenu.scrollTop = topPositon
}
}, 200)

// clearTimeout(scrollCurrentPageMenu, 20000)
Expand Down