Skip to content

CBG-4538 tests: do not expect revSeqNo as a particular value#7675

Merged
gregns1 merged 3 commits into
mainfrom
CBG-4538-take2
Aug 13, 2025
Merged

CBG-4538 tests: do not expect revSeqNo as a particular value#7675
gregns1 merged 3 commits into
mainfrom
CBG-4538-take2

Conversation

@torcolvin
Copy link
Copy Markdown
Collaborator

@torcolvin torcolvin commented Aug 11, 2025

8497bc0 needs extension after merge release/anemone -> main.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

Copilot AI review requested due to automatic review settings August 11, 2025 14:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates test assertions in import tests to handle non-deterministic revision sequence numbers. The changes address an issue where revision sequence numbers can start at the maximum CAS value of any previously deleted document, making specific value assertions unreliable.

  • Replaced exact revision sequence number assertions with range checks
  • Updated comments to explain why specific revSeqNo values cannot be asserted
  • Changed from require.Equal to require.Greater for revision sequence comparisons

@gregns1 gregns1 merged commit 4bd593a into main Aug 13, 2025
42 checks passed
@gregns1 gregns1 deleted the CBG-4538-take2 branch August 13, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants