Skip to content

fix: harden agent mode safety checks#73

Merged
lorenjphillips merged 1 commit into
mainfrom
feat/aci-5-coverage-polish
May 19, 2026
Merged

fix: harden agent mode safety checks#73
lorenjphillips merged 1 commit into
mainfrom
feat/aci-5-coverage-polish

Conversation

@lorenjphillips

@lorenjphillips lorenjphillips commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add focused agent-mode regression coverage for structured parse errors and --agent precedence over --format json.
  • Lock down explicit local skill-source behavior so manifests do not advertise an embedded or remote catalog.
  • Mark skill install next-actions as mutating, reject path-traversal skill IDs, and make runs context launch argv include required placeholders.

Testing

  • cargo fmt
  • cargo clippy --all-targets -- -D warnings
  • cargo test
  • cargo build --release
  • git diff --check
  • Manual release-binary smoke for manifest, skills next-action safety, and runs context argv
  • Parallel subagent smoke lanes for discovery, skills, structured input, next-actions, full verification, and static audit

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b430ba54-8991-4cfb-9c0e-949caf2db454

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/aci-5-coverage-polish

Comment @coderabbitai help to get the list of available commands and usage tips.

@lorenjphillips lorenjphillips force-pushed the feat/aci-5-coverage-polish branch from c612a63 to 669c30e Compare May 19, 2026 00:57
@lorenjphillips lorenjphillips changed the title test: add agent mode coverage polish fix: harden agent mode safety checks May 19, 2026
@lorenjphillips lorenjphillips force-pushed the feat/aci-5-coverage-polish branch from 669c30e to 4dc2883 Compare May 19, 2026 03:06
@lorenjphillips lorenjphillips force-pushed the feat/aci-5-coverage-polish branch from 4dc2883 to ec68a6a Compare May 19, 2026 03:11
@lorenjphillips lorenjphillips force-pushed the feat/aci-5-coverage-polish branch 2 times, most recently from 6184575 to bcb7a9f Compare May 19, 2026 03:23
@lorenjphillips lorenjphillips force-pushed the feat/aci-4-skills branch 2 times, most recently from 8f05010 to 6972b43 Compare May 19, 2026 15:40
@lorenjphillips lorenjphillips force-pushed the feat/aci-5-coverage-polish branch 2 times, most recently from 04b878f to d74758f Compare May 19, 2026 15:51
Comment thread src/commands/agent.rs

@callumreid callumreid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like rust to me!

@lorenjphillips lorenjphillips force-pushed the feat/aci-5-coverage-polish branch from d74758f to 77e1f50 Compare May 19, 2026 20:09
@lorenjphillips lorenjphillips force-pushed the feat/aci-5-coverage-polish branch from 77e1f50 to 2b6a5f5 Compare May 19, 2026 20:20
@lorenjphillips lorenjphillips changed the base branch from feat/aci-4-skills to main May 19, 2026 20:32
@lorenjphillips lorenjphillips merged commit a4c2246 into main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants